ci: remove pdf tests from windows short tests #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes pdf tests from windows short tests
|
I didn't know if I was meant to delete the "Install pdftotext, reportlab and cve-bin-tool" so feel free to correct me :) |
terriko
requested changes
Dec 21, 2022
There was a problem hiding this comment.
Yes to removing the install pdftotext section.
But it looks like you removed the lines in the windows long tests section instead of the windows short test section. Could you swap that? If your editor does line numbers the lines you need to remove start at line 297.
Codecov Report
@@ Coverage Diff @@
## main #2465 +/- ##
==========================================
+ Coverage 77.79% 77.94% +0.14%
==========================================
Files 581 591 +10
Lines 9679 9729 +50
Branches 1319 1319
==========================================
+ Hits 7530 7583 +53
+ Misses 1847 1844 -3
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
terriko
requested changes
Dec 22, 2022
terriko
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes pdf tests from windows short tests
fixes: #2464